updated CONTRIBUTING.md; fixed typos

- signed-off-by: trimstray <trimstray@gmail.com>
This commit is contained in:
trimstray
2019-01-22 09:45:09 +01:00
parent 66c1763738
commit f98cf1c27d
3 changed files with 3 additions and 23 deletions

View File

@@ -1,32 +1,15 @@
# Contributing # Contributing
If you would like to support this project, you have an interesting idea how to improve the operation of this tool or if you found some errors - do fork this add your fixes and add pull-request of your branch to the **testing branch**. If you would like to support this project, you have an interesting idea how to improve the operation of this tool or if you found some errors - do fork this add your fixes and add pull-request of your branch to the **master branch**.
## Bash style
I would like you to stick to certain standards of writing in bash. I realize that it is not easy and time-consuming if you have certain habits. I do not expect 100% compliance and adherence to good practices, however, I would like you to try to use certain principles.
The following should help:
- [http://wiki.bash-hackers.org/](http://wiki.bash-hackers.org/)
- [https://google.github.io/styleguide/shell.xml](https://google.github.io/styleguide/shell.xml)
- [https://github.com/progrium/bashstyle](https://github.com/progrium/bashstyle)
- [http://kvz.io/blog/2013/11/21/bash-best-practices/](http://kvz.io/blog/2013/11/21/bash-best-practices/)
## Shellcheck
One of the requirements before approving your changes is to check them with the **shellcheck** utility. If the returned errors are not critical (eg. [SC2154](https://github.com/koalaman/shellcheck/wiki/SC2154)) you can use the `shellcheck disable=SC2154` design.
## Signature of commit ## Signature of commit
Moving forward all commits to this project must include a "signed-off-by" line indicating the name and email address of the contributor signing off on the change. To enable signatures add the following lines to `.git/hooks/prepare-commit-msg` : Moving forward all commits to this project must include a "signed-off-by" line indicating the name and email address of the contributor signing off on the change. To enable signatures add the following lines to `.git/hooks/prepare-commit-msg` :
`````` ```
SOB=$(git var GIT_AUTHOR_IDENT | sed -n 's/^\(.*>\).*$/- signed-off-by: \1/p') SOB=$(git var GIT_AUTHOR_IDENT | sed -n 's/^\(.*>\).*$/- signed-off-by: \1/p')
grep -qs "^$SOB" "$1" || echo "$SOB" >> "$1" grep -qs "^$SOB" "$1" || echo "$SOB" >> "$1"
`````` ```
## Pull requests ## Pull requests
@@ -35,5 +18,3 @@ When creating pull request, please heed the following:
- Base your code on the latest master branch to avoid manual merges - Base your code on the latest master branch to avoid manual merges
- Code review may ensue in order to help shape your proposal - Code review may ensue in order to help shape your proposal
- Explain the problem and your proposed solution - Explain the problem and your proposed solution

View File

@@ -673,4 +673,3 @@ library, you may consider it more useful to permit linking proprietary
applications with the library. If this is what you want to do, use the applications with the library. If this is what you want to do, use the
GNU Lesser General Public License instead of this License. But first, GNU Lesser General Public License instead of this License. But first,
please read <http://www.gnu.org/philosophy/why-not-lgpl.html>. please read <http://www.gnu.org/philosophy/why-not-lgpl.html>.

View File