mirror of
https://github.com/Security-Onion-Solutions/securityonion.git
synced 2026-09-20 14:49:38 +02:00
Josh Patterson
1e86be11b2
Salt installed the so-* scripts into /usr/sbin owned by unprivileged service UIDs (939/socore, plus 930-960 per service) at mode 755, while root executes those same files from cron, systemd and state cmd.run. Any file-write primitive as one of those UIDs was therefore root. Two mechanisms behind this are not visible in the diff: file.recurse also manages the destination directory, so /usr/sbin itself was chowned to whichever service UID ran last. A directory's owner may always chmod it, so that UID could replace even the scripts already declared user: root -- so-config-backup, so-suricata-eve-clean, so-nsm-mount-nvme. usr_sbin_perms now pins the directory to root:root 555, the mode the filesystem RPM ships. Omitting user:/group: is a no-op on files that already exist, because check_perms only chowns when a user is named. Explicit user: root is what lets upgraded grids self-heal on the next highstate, and what makes a revert chown back rather than silently do nothing.
21 lines
471 B
YAML+Jinja
21 lines
471 B
YAML+Jinja
python3_lief:
|
|
pkg.installed:
|
|
- name: securityonion-python3-lief
|
|
|
|
so-fix-salt-ldap_script:
|
|
file.managed:
|
|
- name: /usr/sbin/so-fix-salt-ldap.py
|
|
- source: salt://libvirt/64962/scripts/so-fix-salt-ldap.py
|
|
- user: root
|
|
- group: root
|
|
- mode: 744
|
|
|
|
fix-salt-ldap:
|
|
cmd.run:
|
|
- name: /usr/sbin/so-fix-salt-ldap.py
|
|
- require:
|
|
- pkg: python3_lief
|
|
- file: so-fix-salt-ldap_script
|
|
- onchanges:
|
|
- file: so-fix-salt-ldap_script
|