mirror of
https://github.com/Security-Onion-Solutions/securityonion.git
synced 2026-09-20 14:49:38 +02:00
Josh Patterson
1e86be11b2
Salt installed the so-* scripts into /usr/sbin owned by unprivileged service UIDs (939/socore, plus 930-960 per service) at mode 755, while root executes those same files from cron, systemd and state cmd.run. Any file-write primitive as one of those UIDs was therefore root. Two mechanisms behind this are not visible in the diff: file.recurse also manages the destination directory, so /usr/sbin itself was chowned to whichever service UID ran last. A directory's owner may always chmod it, so that UID could replace even the scripts already declared user: root -- so-config-backup, so-suricata-eve-clean, so-nsm-mount-nvme. usr_sbin_perms now pins the directory to root:root 555, the mode the filesystem RPM ships. Omitting user:/group: is a no-op on files that already exist, because check_perms only chowns when a user is named. Explicit user: root is what lets upgraded grids self-heal on the next highstate, and what makes a revert chown back rather than silently do nothing.
73 lines
1.6 KiB
YAML+Jinja
73 lines
1.6 KiB
YAML+Jinja
# Copyright Security Onion Solutions LLC and/or licensed to Security Onion Solutions LLC under one
|
|
# or more contributor license agreements. Licensed under the Elastic License 2.0 as shown at
|
|
# https://securityonion.net/license; you may not use this file except in compliance with the
|
|
# Elastic License 2.0.
|
|
|
|
{% from 'allowed_states.map.jinja' import allowed_states %}
|
|
{% if sls.split('.')[0] in allowed_states %}
|
|
{% from 'redis/map.jinja' import REDISMERGED %}
|
|
|
|
# Redis Setup
|
|
redisconfdir:
|
|
file.directory:
|
|
- name: /opt/so/conf/redis/etc
|
|
- user: 939
|
|
- group: 939
|
|
- makedirs: True
|
|
|
|
redisworkdir:
|
|
file.directory:
|
|
- name: /opt/so/conf/redis/working
|
|
- user: 939
|
|
- group: 939
|
|
- makedirs: True
|
|
|
|
redisdatadir:
|
|
file.directory:
|
|
- name: /nsm/redis/data
|
|
- user: 939
|
|
- group: 939
|
|
- makedirs: True
|
|
|
|
redislogdir:
|
|
file.directory:
|
|
- name: /opt/so/log/redis
|
|
- user: 939
|
|
- group: 939
|
|
- makedirs: True
|
|
|
|
redisconf:
|
|
file.managed:
|
|
- name: /opt/so/conf/redis/etc/redis.conf
|
|
- source: salt://redis/etc/redis.conf.jinja
|
|
- user: 939
|
|
- group: 939
|
|
- template: jinja
|
|
- defaults:
|
|
REDISMERGED: {{ REDISMERGED }}
|
|
|
|
redis_sbin:
|
|
file.recurse:
|
|
- name: /usr/sbin
|
|
- source: salt://redis/tools/sbin
|
|
- user: root
|
|
- group: root
|
|
- file_mode: 755
|
|
|
|
redis_sbin_jinja:
|
|
file.recurse:
|
|
- name: /usr/sbin
|
|
- source: salt://redis/tools/sbin_jinja
|
|
- user: root
|
|
- group: root
|
|
- file_mode: 755
|
|
- template: jinja
|
|
|
|
{% else %}
|
|
|
|
{{sls}}_state_not_allowed:
|
|
test.fail_without_changes:
|
|
- name: {{sls}}_state_not_allowed
|
|
|
|
{% endif %}
|