mirror of
https://github.com/Security-Onion-Solutions/securityonion.git
synced 2026-09-20 14:49:38 +02:00
Josh Patterson
1e86be11b2
Salt installed the so-* scripts into /usr/sbin owned by unprivileged service UIDs (939/socore, plus 930-960 per service) at mode 755, while root executes those same files from cron, systemd and state cmd.run. Any file-write primitive as one of those UIDs was therefore root. Two mechanisms behind this are not visible in the diff: file.recurse also manages the destination directory, so /usr/sbin itself was chowned to whichever service UID ran last. A directory's owner may always chmod it, so that UID could replace even the scripts already declared user: root -- so-config-backup, so-suricata-eve-clean, so-nsm-mount-nvme. usr_sbin_perms now pins the directory to root:root 555, the mode the filesystem RPM ships. Omitting user:/group: is a no-op on files that already exist, because check_perms only chowns when a user is named. Explicit user: root is what lets upgraded grids self-heal on the next highstate, and what makes a revert chown back rather than silently do nothing.
134 lines
2.9 KiB
YAML+Jinja
134 lines
2.9 KiB
YAML+Jinja
# Copyright Security Onion Solutions LLC and/or licensed to Security Onion Solutions LLC under one
|
|
# or more contributor license agreements. Licensed under the Elastic License 2.0 as shown at
|
|
# https://securityonion.net/license; you may not use this file except in compliance with the
|
|
# Elastic License 2.0.
|
|
|
|
{% from 'allowed_states.map.jinja' import allowed_states %}
|
|
{% if sls.split('.')[0] in allowed_states %}
|
|
|
|
{% from 'elastalert/map.jinja' import ELASTALERTMERGED %}
|
|
|
|
# Create the group
|
|
elastagroup:
|
|
group.present:
|
|
- name: elastalert
|
|
- gid: 933
|
|
|
|
# Add user
|
|
elastalert:
|
|
user.present:
|
|
- uid: 933
|
|
- gid: 933
|
|
- home: /opt/so/conf/elastalert
|
|
- createhome: False
|
|
|
|
elastalogdir:
|
|
file.directory:
|
|
- name: /opt/so/log/elastalert
|
|
- user: 933
|
|
- group: 933
|
|
- makedirs: True
|
|
|
|
elastalert_sbin:
|
|
file.recurse:
|
|
- name: /usr/sbin
|
|
- source: salt://elastalert/tools/sbin
|
|
- user: root
|
|
- group: root
|
|
- file_mode: 755
|
|
|
|
#elastalert_sbin_jinja:
|
|
# file.recurse:
|
|
# - name: /usr/sbin
|
|
# - source: salt://elastalert/tools/sbin_jinja
|
|
# - user: 933
|
|
# - group: 939
|
|
# - file_mode: 755
|
|
# - template: jinja
|
|
|
|
elastarules:
|
|
file.directory:
|
|
- name: /opt/so/rules/elastalert
|
|
- user: 933
|
|
- group: 933
|
|
- makedirs: True
|
|
|
|
elastaconfdir:
|
|
file.directory:
|
|
- name: /opt/so/conf/elastalert
|
|
- user: 933
|
|
- group: 933
|
|
- makedirs: True
|
|
|
|
elastasomodulesdir:
|
|
file.directory:
|
|
- name: /opt/so/conf/elastalert/modules/so
|
|
- user: 933
|
|
- group: 933
|
|
- makedirs: True
|
|
|
|
elastacustmodulesdir:
|
|
file.directory:
|
|
- name: /opt/so/conf/elastalert/modules/custom
|
|
- user: 933
|
|
- group: 933
|
|
- makedirs: True
|
|
|
|
elastasomodulesync:
|
|
file.recurse:
|
|
- name: /opt/so/conf/elastalert/modules/so
|
|
- source: salt://elastalert/files/modules/so
|
|
- user: 933
|
|
- group: 933
|
|
- makedirs: True
|
|
|
|
elastacustomdir:
|
|
file.directory:
|
|
- name: /opt/so/conf/elastalert/custom
|
|
- user: 933
|
|
- group: 933
|
|
- makedirs: True
|
|
|
|
elastacustomsync:
|
|
file.recurse:
|
|
- name: /opt/so/conf/elastalert/custom
|
|
- source: salt://elastalert/files/custom
|
|
- user: 933
|
|
- group: 933
|
|
- makedirs: True
|
|
- file_mode: 660
|
|
- show_changes: False
|
|
|
|
elastapredefinedsync:
|
|
file.recurse:
|
|
- name: /opt/so/conf/elastalert/predefined
|
|
- source: salt://elastalert/files/predefined
|
|
- user: 933
|
|
- group: 933
|
|
- makedirs: True
|
|
- template: jinja
|
|
- file_mode: 660
|
|
- context:
|
|
elastalert: {{ ELASTALERTMERGED }}
|
|
- show_changes: False
|
|
|
|
elastaconf:
|
|
file.managed:
|
|
- name: /opt/so/conf/elastalert/elastalert_config.yaml
|
|
- source: salt://elastalert/files/elastalert_config.yaml.jinja
|
|
- context:
|
|
elastalert_config: {{ ELASTALERTMERGED.config }}
|
|
- user: 933
|
|
- group: 933
|
|
- mode: 660
|
|
- template: jinja
|
|
- show_changes: False
|
|
|
|
{% else %}
|
|
|
|
{{sls}}_state_not_allowed:
|
|
test.fail_without_changes:
|
|
- name: {{sls}}_state_not_allowed
|
|
|
|
{% endif %}
|