mirror of
https://github.com/Security-Onion-Solutions/securityonion.git
synced 2026-10-08 07:15:27 +02:00
Josh Patterson
21222ff119
These accounts existed only for container UID mapping and filesystem ownership, but user.present omitted shell:, so Salt fell through to the platform useradd default and every one of them got /bin/bash. Pin them to /sbin/nologin so none can be used as an interactive login or `su -` target. socore keeps /bin/bash: `su socore -c '/usr/sbin/so-repo-sync'` in soup and so-kernel-upgrade execs the account's passwd shell, and operator docs tell users to su to socore. soqemussh keeps /bin/bash as an SSH login account. elastic-agent, elastic-agent-pr and kafka are included alongside the accounts named in the issue, being the same class with the same unset shell, so the default is uniform. Cron is unaffected: cronie runs jobs via the crontab SHELL (default /bin/sh), not the passwd shell. suricata is the only account changed here that owns a crontab, and somon has shipped as nologin with a working cron job already. The zeek `runuser -l zeek` calls all run inside so-zeek via docker.run/exec, so they resolve the shell from the image, not the host. Verified on a 3.4.0 managersearch + sensor grid: highstate converges with the shell as the only change and no failures, is idempotent on a second run, all containers stay up, SOC still issues a Kratos login flow, and the suricata surilogcompress cron job runs post-change ((suricata) CMD/CMDEND in /var/log/cron) while `su - suricata` is now refused. Closes #16256
64 lines
1.5 KiB
YAML+Jinja
64 lines
1.5 KiB
YAML+Jinja
# Copyright Security Onion Solutions LLC and/or licensed to Security Onion Solutions LLC under one
|
|
# or more contributor license agreements. Licensed under the Elastic License 2.0 as shown at
|
|
# https://securityonion.net/license; you may not use this file except in compliance with the
|
|
# Elastic License 2.0.
|
|
|
|
{% from 'allowed_states.map.jinja' import allowed_states %}
|
|
{% from 'vars/globals.map.jinja' import GLOBALS %}
|
|
{% if sls.split('.')[0] in allowed_states %}
|
|
|
|
# Add EA Group
|
|
elasticagentgroup:
|
|
group.present:
|
|
- name: elastic-agent
|
|
- gid: 949
|
|
|
|
# Add EA user
|
|
elastic-agent:
|
|
user.present:
|
|
- uid: 949
|
|
- gid: 949
|
|
- home: /opt/so/conf/elastic-agent
|
|
- createhome: False
|
|
- shell: /sbin/nologin
|
|
|
|
elasticagentconfdir:
|
|
file.directory:
|
|
- name: /opt/so/conf/elastic-agent
|
|
- user: 949
|
|
- group: 939
|
|
- makedirs: True
|
|
|
|
elasticagentlogdir:
|
|
file.directory:
|
|
- name: /opt/so/log/elasticagent
|
|
- user: 949
|
|
- group: 939
|
|
- makedirs: True
|
|
|
|
elasticagent_sbin_jinja:
|
|
file.recurse:
|
|
- name: /usr/sbin
|
|
- source: salt://elasticagent/tools/sbin_jinja
|
|
- user: root
|
|
- group: root
|
|
- file_mode: 755
|
|
- template: jinja
|
|
|
|
# Create config
|
|
create-elastic-agent-config:
|
|
file.managed:
|
|
- name: /opt/so/conf/elastic-agent/elastic-agent.yml
|
|
- source: salt://elasticagent/files/elastic-agent.yml.jinja
|
|
- user: 949
|
|
- group: 939
|
|
- template: jinja
|
|
|
|
{% else %}
|
|
|
|
{{sls}}_state_not_allowed:
|
|
test.fail_without_changes:
|
|
- name: {{sls}}_state_not_allowed
|
|
|
|
{% endif %}
|