From f7600af89b42c068d809c43233c35ad4c03b7b79 Mon Sep 17 00:00:00 2001
From: m0duspwnens <josh.patterson@securityonionsolutions.com>
Date: Fri, 11 Jun 2021 13:52:33 -0400
Subject: [PATCH] dont loop if modules arent defined for the node

---
 salt/filebeat/etc/module_config.yml.jinja | 22 ++++++++++++----------
 1 file changed, 12 insertions(+), 10 deletions(-)

diff --git a/salt/filebeat/etc/module_config.yml.jinja b/salt/filebeat/etc/module_config.yml.jinja
index 8f4fbd7bf..733d47c7e 100644
--- a/salt/filebeat/etc/module_config.yml.jinja
+++ b/salt/filebeat/etc/module_config.yml.jinja
@@ -1,16 +1,18 @@
 # DO NOT EDIT THIS FILE
-{% for module in MODULES.modules.keys() %}
+{%- if MODULES.modules is iterable and MODULES.modules is not string and MODULES.modules|length > 0%}
+  {%- for module in MODULES.modules.keys() %}
 - module: {{ module }}
-  {%- for fileset in MODULES.modules[module] %}
+    {%- for fileset in MODULES.modules[module] %}
   {{ fileset }}:
     enabled: {{ MODULES.modules[module][fileset].enabled|string|lower }}
-    {#- only manage the settings if the fileset is enabled #}
-    {%- if MODULES.modules[module][fileset].enabled %}
-      {%- for var, value in MODULES.modules[module][fileset].items() %}
-        {%- if var|lower != 'enabled' %}
+      {#- only manage the settings if the fileset is enabled #}
+      {%- if MODULES.modules[module][fileset].enabled %}
+        {%- for var, value in MODULES.modules[module][fileset].items() %}
+          {%- if var|lower != 'enabled' %}
     {{ var }}: {{ value }}
-        {%- endif %}
-      {%- endfor %}
-    {%- endif %}
+          {%- endif %}
+        {%- endfor %}
+      {%- endif %}
+    {%- endfor %}
   {%- endfor %}
-{% endfor %}
+{% endif %}