CSEC_PUBLIC/securityonion
1
0
Fork 0
mirror of https://github.com/Security-Onion-Solutions/securityonion.git synced 2025-12-09 02:32:46 +01:00
Code Issues Packages Projects Releases Wiki Activity

Improve unit test stability

Browse Source
This commit is contained in:
Jason Ertel
2022-04-05 07:36:25 -04:00
parent d2fa80e48a
commit d8defdd7b0
2 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
salt/sensoroni/files/analyzers/helpers_test.py
View File

@@ -1,5 +1,6 @@
from unittest.mock import patch, MagicMock from unittest.mock import patch, MagicMock
import helpers import helpers
import os
import unittest import unittest
@@ -14,10 +15,11 @@ class TestHelpersMethods(unittest.TestCase):
result = helpers.checkSupportedType(meta, "bar") result = helpers.checkSupportedType(meta, "bar")
self.assertFalse(result) self.assertFalse(result)
mock.assert_called_once_with("No supported type detected!") mock.assert_called_once_with(126)
def test_loadMetadata(self): def test_loadMetadata(self):
input = 'urlhaus/urlhaus.py' dir = os.path.dirname(os.path.realpath(__file__))
input = dir + '/urlhaus/urlhaus.py'
data = helpers.loadMetadata(input) data = helpers.loadMetadata(input)
self.assertEqual(data["name"], "Urlhaus") self.assertEqual(data["name"], "Urlhaus")

8
salt/sensoroni/files/analyzers/urlhaus/urlhaus_test.py
View File

@@ -13,7 +13,7 @@ class TestUrlhausMethods(unittest.TestCase):
urlhaus.main() urlhaus.main()
expected = '{"foo": "bar"}\n' expected = '{"foo": "bar"}\n'
self.assertEqual(mock_stdout.getvalue(), expected) self.assertEqual(mock_stdout.getvalue(), expected)
mock.assert_called_once_with('.') mock.assert_called_once()
def test_buildReq(self): def test_buildReq(self):
result = urlhaus.buildReq("test") result = urlhaus.buildReq("test")
@@ -31,14 +31,14 @@ class TestUrlhausMethods(unittest.TestCase):
results = urlhaus.prepareResults(raw) results = urlhaus.prepareResults(raw)
self.assertEqual(results["response"], raw) self.assertEqual(results["response"], raw)
self.assertEqual(results["summary"], "no_results") self.assertEqual(results["summary"], "no_results")
self.assertEqual(results["status"], "info") self.assertEqual(results["status"], "ok")
def test_prepareResults_invalidUrl(self): def test_prepareResults_invalidUrl(self):
raw = {"query_status": "invalid_url"} raw = {"query_status": "invalid_url"}
results = urlhaus.prepareResults(raw) results = urlhaus.prepareResults(raw)
self.assertEqual(results["response"], raw) self.assertEqual(results["response"], raw)
self.assertEqual(results["summary"], "invalid_url") self.assertEqual(results["summary"], "invalid_url")
self.assertEqual(results["status"], "error") self.assertEqual(results["status"], "caution")
def test_prepareResults_threat(self): def test_prepareResults_threat(self):
raw = {"query_status": "invalid_url"} # This is overrided in this scenario raw = {"query_status": "invalid_url"} # This is overrided in this scenario
@@ -46,7 +46,7 @@ class TestUrlhausMethods(unittest.TestCase):
results = urlhaus.prepareResults(raw) results = urlhaus.prepareResults(raw)
self.assertEqual(results["response"], raw) self.assertEqual(results["response"], raw)
self.assertEqual(results["summary"], "bad_actor") self.assertEqual(results["summary"], "bad_actor")
self.assertEqual(results["status"], "danger") self.assertEqual(results["status"], "threat")
def test_analyze(self): def test_analyze(self):
output = {"threat": "malware_download"} output = {"threat": "malware_download"}