From d71967ea1db09c37cc25b2e7e4304219321a2bdb Mon Sep 17 00:00:00 2001 From: William Wernert Date: Fri, 30 Jul 2021 10:28:39 -0400 Subject: [PATCH] Fix incorrect writing of so-status.conf --- salt/common/tools/sbin/so-learn | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/salt/common/tools/sbin/so-learn b/salt/common/tools/sbin/so-learn index 8103dc09b..815d78ebf 100644 --- a/salt/common/tools/sbin/so-learn +++ b/salt/common/tools/sbin/so-learn @@ -100,7 +100,7 @@ def write_pillar(pillar: str, content: dict): sys.exit(3) -def mod_so_status(action: str, items: str): +def mod_so_status(action: str, items: List): with open(so_status_conf, 'a+') as conf: conf.seek(0) containers = conf.readlines() @@ -112,6 +112,8 @@ def mod_so_status(action: str, items: str): else: if action == 'remove': pass if action == 'add': containers.append(f'so-{item}\n') + + [containers.remove(c_name) for c_name in containers if c_name == '\n'] # remove extra newlines conf.seek(0) conf.truncate(0)