From 8080e054444ad4d42647d8d414b4be4ae4e3f3bd Mon Sep 17 00:00:00 2001
From: reyesj2 <94730068+reyesj2@users.noreply.github.com>
Date: Fri, 14 Jun 2024 14:17:26 -0400
Subject: [PATCH 1/2] on fresh install kafka nodes pillar may not have
 populated. Avoiding this by only generating kafka input pipeline when kafka
 nodes pillar is not empty

Signed-off-by: reyesj2 <94730068+reyesj2@users.noreply.github.com>
---
 .../config/so/0800_input_kafka.conf.jinja      | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/salt/logstash/pipelines/config/so/0800_input_kafka.conf.jinja b/salt/logstash/pipelines/config/so/0800_input_kafka.conf.jinja
index 9e80456f2..33a4d39e4 100644
--- a/salt/logstash/pipelines/config/so/0800_input_kafka.conf.jinja
+++ b/salt/logstash/pipelines/config/so/0800_input_kafka.conf.jinja
@@ -1,13 +1,14 @@
 {%- set kafka_password = salt['pillar.get']('kafka:password') %}
-{%- set kafka_brokers = salt['pillar.get']('kafka:nodes', {}) %}
+{%- set kafka_brokers = salt['pillar.get']('kafka:nodes', default=None) %}
 {%- set brokers = [] %}
 
-{%- for key, values in kafka_brokers.items() %}
-{%-   if 'broker' in values['role'] %}
-{%-     do brokers.append(key ~ ':9092') %}
-{%-   endif %}
-{%- endfor %}
-{%- set bootstrap_servers = ','.join(brokers) %}
+{%- if kafka_brokers != none %}
+{%-   for key, values in kafka_brokers.items() %}
+{%-     if 'broker' in values['role'] %}
+{%-       do brokers.append(key ~ ':9092') %}
+{%-     endif %}
+{%-   endfor %}
+{%-   set bootstrap_servers = ','.join(brokers) %}
 
 input {
     kafka {
@@ -33,4 +34,5 @@ filter {
       rename => { "@metadata" => "metadata" }
     }
   }
-}
\ No newline at end of file
+}
+{% endif %}
\ No newline at end of file

From a0030b27e231fc0bc9411979516e22799e2fd6cd Mon Sep 17 00:00:00 2001
From: reyesj2 <94730068+reyesj2@users.noreply.github.com>
Date: Fri, 14 Jun 2024 15:34:40 -0400
Subject: [PATCH 2/2] add additional retries to elasticfleet scripts

Signed-off-by: reyesj2 <94730068+reyesj2@users.noreply.github.com>
---
 salt/elasticfleet/enabled.sls | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/salt/elasticfleet/enabled.sls b/salt/elasticfleet/enabled.sls
index 50290bf09..af5e552eb 100644
--- a/salt/elasticfleet/enabled.sls
+++ b/salt/elasticfleet/enabled.sls
@@ -27,7 +27,9 @@ wait_for_elasticsearch_elasticfleet:
 so-elastic-fleet-auto-configure-logstash-outputs:
   cmd.run:
     - name: /usr/sbin/so-elastic-fleet-outputs-update
-    - retry: True
+    - retry:
+        attempts: 4
+        interval: 30
 {% endif %}
 
 # If enabled, automatically update Fleet Server URLs & ES Connection
@@ -35,7 +37,9 @@ so-elastic-fleet-auto-configure-logstash-outputs:
 so-elastic-fleet-auto-configure-server-urls:
   cmd.run:
     - name: /usr/sbin/so-elastic-fleet-urls-update
-    - retry: True
+    - retry:
+        attempts: 4
+        interval: 30
 {% endif %}
 
 # Automatically update Fleet Server Elasticsearch URLs & Agent Artifact URLs
@@ -43,12 +47,16 @@ so-elastic-fleet-auto-configure-server-urls:
 so-elastic-fleet-auto-configure-elasticsearch-urls:
   cmd.run:
     - name: /usr/sbin/so-elastic-fleet-es-url-update
-    - retry: True
+    - retry:
+        attempts: 4
+        interval: 30
 
 so-elastic-fleet-auto-configure-artifact-urls:
   cmd.run:
     - name: /usr/sbin/so-elastic-fleet-artifacts-url-update
-    - retry: True 
+    - retry:
+        attempts: 4
+        interval: 30
 
 {% endif %}