From cc5565d5bc1fe95993076fe0a5736fba5e5e9359 Mon Sep 17 00:00:00 2001
From: m0duspwnens <josh.patterson@securityonionsolutions.com>
Date: Mon, 18 Nov 2019 15:33:21 -0500
Subject: [PATCH] fix needs_restarting module

---
 salt/_modules/needs_restarting.py | 7 +++----
 salt/motd/init.sls                | 2 +-
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/salt/_modules/needs_restarting.py b/salt/_modules/needs_restarting.py
index 49f82bbf2..5afb6f02a 100644
--- a/salt/_modules/needs_restarting.py
+++ b/salt/_modules/needs_restarting.py
@@ -4,20 +4,19 @@ import subprocess
 def check():
 
   os = __grains__['os']
+  retval = 'False'
 
   if os == 'Ubuntu':
     if path.exists('/var/run/reboot-required'):
       retval = 'True'
-    else:
-      retval = 'False'
 
   elif os == 'CentOS':
     cmd = 'needs-restarting -r > /dev/null 2>&1'
+    
     try:
-      needs_restarting = subprocess.check_call(cmd.split(), shell=True)
+      needs_restarting = subprocess.check_call(cmd, shell=True)
     except subprocess.CalledProcessError:
       retval = 'True'
-    retval = 'False'
 
   else:
     retval = 'Unsupported OS: %s' % os
diff --git a/salt/motd/init.sls b/salt/motd/init.sls
index a314ddb80..4dae979bf 100644
--- a/salt/motd/init.sls
+++ b/salt/motd/init.sls
@@ -1,5 +1,5 @@
 package_update_reboot_required_motd:
-  file.append:
+  file.managed:
     - name: /etc/motd
     - source: salt://motd/files/package_update_reboot_required.jinja
     - template: jinja