From 70053e362cdfae2415dbcb5d50e2ffa545f55c77 Mon Sep 17 00:00:00 2001 From: Josh Patterson Date: Mon, 16 Nov 2026 10:20:05 -0500 Subject: [PATCH] FIX: exclude the drainer's push-result-unknown warning from so-log-check so-push-drainer logs "push result unknown" as a WARNING when salt-master restarts while a pushed state run is queued: the orchestration's next publish fails with AuthenticationError, but the minion still runs the queued state. so-log-check matches any line containing "error", so the quoted exception still failed the check. Reproduced on a distributed 3.5.0 grid: a sensoroni push queued behind a 150s state run on the manager, then salt-master was restarted. The orchestration (which runs under salt-minion.service, so it survives the restart) raised AuthenticationError 9s later, the drainer logged the WARNING, and the queued state run completed with 0 failed states. so-log-check --unknown flagged the line. The pattern requires AuthenticationError so an unknown result from any other raised exception, e.g. a bug in a state module, is still reported. --- salt/common/tools/sbin/so-log-check | 1 + 1 file changed, 1 insertion(+) diff --git a/salt/common/tools/sbin/so-log-check b/salt/common/tools/sbin/so-log-check index 73e7feedc..9f3025fdc 100755 --- a/salt/common/tools/sbin/so-log-check +++ b/salt/common/tools/sbin/so-log-check @@ -244,6 +244,7 @@ if [[ $EXCLUDE_KNOWN_ERRORS == 'Y' ]]; then EXCLUDED_ERRORS="$EXCLUDED_ERRORS|TransformTask\] \[logs-.*user so_kibana lacks the required permissions" # Known issue with integrations starting transform jobs that are explicitly not allowed to start as a system user EXCLUDED_ERRORS="$EXCLUDED_ERRORS|manifest unknown" # so-dockerregistry logs a tag lookup miss during image copy; not tied to one docker version EXCLUDED_ERRORS="$EXCLUDED_ERRORS|Could not index event to Elasticsearch.*\"version\" => \"9.0.8\"" # Expected during Elastic upgrade temporarily, as policies referencing older pipelines are updated + EXCLUDED_ERRORS="$EXCLUDED_ERRORS|push result unknown.*AuthenticationError" # so-push-drainer WARNING: salt-master restarted while a push was queued; the queued state run still completes fi RESULT=0