Merge remote-tracking branch 'remotes/origin/dev' into issue/1403

salt/common/tools/sbin/so-common

@@ -33,12 +33,12 @@ header() {
 
 lookup_pillar() {
     key=$1
-    cat /opt/so/saltstack/local/pillar/global.sls | grep $key | awk '{print $2}'
+    salt-call --no-color  pillar.get global:${key} --out=newline_values_only
 }
 
 lookup_pillar_secret() {
     key=$1
-    cat /opt/so/saltstack/local/pillar/secrets.sls | grep $key | awk '{print $2}'
+    salt-call --no-color  pillar.get secrets:${key} --out=newline_values_only
 }
 
 check_container() {

salt/common/tools/sbin/soup

@@ -258,6 +258,12 @@ rc3_to_2.3.0() {
       echo "playbook:"
       echo "  api_key: de6639318502476f2fa5aa06f43f51fb389a3d7f" 
   } >> /opt/so/saltstack/local/pillar/global.sls
+
+  sed -i 's/playbook:/playbook_db:/' /opt/so/saltstack/local/pillar/secrets.sls
+  {
+    echo "playbook_admin: $(tr -dc 'a-zA-Z0-9' < /dev/urandom | fold -w 20 | head -n 1)"
+    echo "playbook_automation: $(tr -dc 'a-zA-Z0-9' < /dev/urandom | fold -w 20 | head -n 1)"
+  } >> /opt/so/saltstack/local/pillar/secrets.sls
 }
 
 space_check() {

salt/playbook/automation_user_create.sls

@@ -5,11 +5,12 @@
 include:
   - playbook
   
-cmd.run:
+wait_for_playbook:
-  - name: until nc -z {{ MAINIP }} 3200; do sleep 1; done
+  cmd.run:
-  - timeout: 30
+    - name: until nc -z {{ MAINIP }} 3200; do sleep 1; done
-  - onchanges:
+    - timeout: 30
-    - cmd: create_user
+    - onchanges:
+      - cmd: create_user
 
 create_user:
   cmd.script: