From 171aa1178a1a9ef2f9b858dd534fbe3a32b76dff Mon Sep 17 00:00:00 2001
From: m0duspwnens <josh.patterson@securityonionsolutions.com>
Date: Wed, 29 Jul 2020 14:36:42 -0400
Subject: [PATCH] fix vars and if statement

---
 salt/common/tools/sbin/soup | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/salt/common/tools/sbin/soup b/salt/common/tools/sbin/soup
index f2cc034b6..851f62363 100755
--- a/salt/common/tools/sbin/soup
+++ b/salt/common/tools/sbin/soup
@@ -165,7 +165,7 @@ upgrade_check_salt() {
     if [ "$INSTALLEDSALTVERSION" == "$NEWSALTVERSION" ]; then
       echo "You are already running the correct version of Salt for Security Onion."
     else
-      SALTUPGRADED = True
+      SALTUPGRADED=True
       echo "Performing upgrade of Salt from $INSTALLEDSALTVERSION to $NEWSALTVERSION"
       echo ""
       # If CentOS
@@ -202,7 +202,7 @@ while getopts ":b" opt; do
   case ${opt} in
     b ) # process option b
       if [[ $OPTARG =~ ^?[0-9]+$ ]] && [[ $OPTARG -gt 0 ]]; then
-        BATCHSIZE = $OPTARG
+        BATCHSIZE=$OPTARG
       else
         echo "Batch size must be a number greater than 0"
       fi
@@ -271,7 +271,7 @@ highstate
 echo ""
 echo "Upgrade from $INSTALLEDVERSION to $NEWVERSION complete."
 
-if [ SALTUPGRADED ]; then
+if [ "$SALTUPGRADED" = True ]; then
   echo ""
   echo "Upgrading the remaining Security Onion nodes from $INSTALLEDSALTVERSION to $NEWSALTVERSION"
   salt -C 'not *_eval and not *_helix and not *_manager and not *_managersearch and not *_standalone' -b $BATCHSIZE state.apply salt.minion