mirror of
https://github.com/SecurityBrewery/catalyst.git
synced 2026-01-10 16:23:10 +01:00
feat: improve python actions (#1083)
This commit is contained in:
@@ -15,8 +15,8 @@ type Request struct {
|
||||
IsBase64Encoded bool `json:"isBase64Encoded"`
|
||||
}
|
||||
|
||||
// isJSON checks if the data is JSON.
|
||||
func isJSON(data []byte) bool {
|
||||
// IsJSON checks if the data is JSON.
|
||||
func IsJSON(data []byte) bool {
|
||||
var msg json.RawMessage
|
||||
|
||||
return json.Unmarshal(data, &msg) == nil
|
||||
|
||||
@@ -1,8 +1,14 @@
|
||||
package webhook
|
||||
package webhook_test
|
||||
|
||||
import "testing"
|
||||
import (
|
||||
"testing"
|
||||
|
||||
"github.com/SecurityBrewery/catalyst/reaction/trigger/webhook"
|
||||
)
|
||||
|
||||
func Test_isJSON(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
type args struct {
|
||||
data []byte
|
||||
}
|
||||
@@ -29,7 +35,9 @@ func Test_isJSON(t *testing.T) {
|
||||
}
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
if got := isJSON(tt.args.data); got != tt.want {
|
||||
t.Parallel()
|
||||
|
||||
if got := webhook.IsJSON(tt.args.data); got != tt.want {
|
||||
t.Errorf("isJSON() = %v, want %v", got, tt.want)
|
||||
}
|
||||
})
|
||||
|
||||
@@ -9,6 +9,7 @@ import (
|
||||
|
||||
"github.com/labstack/echo/v5"
|
||||
"github.com/pocketbase/dbx"
|
||||
"github.com/pocketbase/pocketbase"
|
||||
"github.com/pocketbase/pocketbase/apis"
|
||||
"github.com/pocketbase/pocketbase/core"
|
||||
"github.com/pocketbase/pocketbase/daos"
|
||||
@@ -26,22 +27,22 @@ type Webhook struct {
|
||||
|
||||
const prefix = "/reaction/"
|
||||
|
||||
func BindHooks(app core.App) {
|
||||
app.OnBeforeServe().Add(func(e *core.ServeEvent) error {
|
||||
e.Router.Any(prefix+"*", handle(e.App.Dao()))
|
||||
func BindHooks(pb *pocketbase.PocketBase) {
|
||||
pb.OnBeforeServe().Add(func(e *core.ServeEvent) error {
|
||||
e.Router.Any(prefix+"*", handle(e.App))
|
||||
|
||||
return nil
|
||||
})
|
||||
}
|
||||
|
||||
func handle(dao *daos.Dao) func(c echo.Context) error {
|
||||
func handle(app core.App) func(c echo.Context) error {
|
||||
return func(c echo.Context) error {
|
||||
record, payload, apiErr := parseRequest(dao, c.Request())
|
||||
record, payload, apiErr := parseRequest(app.Dao(), c.Request())
|
||||
if apiErr != nil {
|
||||
return apiErr
|
||||
}
|
||||
|
||||
output, err := action.Run(c.Request().Context(), record.GetString("action"), record.GetString("actiondata"), string(payload))
|
||||
output, err := action.Run(c.Request().Context(), app, record.GetString("action"), record.GetString("actiondata"), string(payload))
|
||||
if err != nil {
|
||||
return apis.NewApiError(http.StatusInternalServerError, err.Error(), nil)
|
||||
}
|
||||
@@ -138,7 +139,7 @@ func writeOutput(c echo.Context, output []byte) error {
|
||||
}
|
||||
}
|
||||
|
||||
if isJSON(output) {
|
||||
if IsJSON(output) {
|
||||
return c.JSON(http.StatusOK, json.RawMessage(output))
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user