From 5cfef4af1ecc66e41c8707785e25b8acdf2d9b3a Mon Sep 17 00:00:00 2001 From: fukusuket <41001169+fukusuket@users.noreply.github.com> Date: Sun, 20 Apr 2025 16:17:57 +0900 Subject: [PATCH 01/14] feat: full/rotate check --- WELA.ps1 | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/WELA.ps1 b/WELA.ps1 index 705177f6..33e6ba0d 100644 --- a/WELA.ps1 +++ b/WELA.ps1 @@ -1472,6 +1472,8 @@ function AuditFileSize { Default = $logNames[$logName][0] Recommended = $logNames[$logName][1] CorrectSetting = $correctSetting + IsLogFull = $logInfo.IsLogFull + LogMode = $logInfo.LogMode } } @@ -1483,7 +1485,10 @@ function AuditFileSize { "Max Size", ` "Default", ` "Recommended", ` - "Correct Setting") + "Correct Setting", ` + "Is Log Full", ` + "Log Mode" ` + ) Write-Host ($tableLayout -f ` "--------", ` "------------", ` @@ -1499,7 +1504,10 @@ function AuditFileSize { $result.MaxLogSize, ` $result.Default, ` $result.Recommended, ` - $result.CorrectSetting) -ForegroundColor $color + $result.CorrectSetting, ` + $result.IsLogFull, ` + $result.LogMode ` + ) -ForegroundColor $color } $results | Export-Csv -Path "WELA-FileSize-Result.csv" -NoTypeInformation From ddf8f933975f150247d68fb233dc3d82a06aa108 Mon Sep 17 00:00:00 2001 From: fukusuket <41001169+fukusuket@users.noreply.github.com> Date: Sun, 20 Apr 2025 16:20:13 +0900 Subject: [PATCH 02/14] feat: full/rotate check --- WELA.ps1 | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/WELA.ps1 b/WELA.ps1 index 33e6ba0d..0a65ef7a 100644 --- a/WELA.ps1 +++ b/WELA.ps1 @@ -1478,7 +1478,7 @@ function AuditFileSize { } # Format-Tableには色つき出力の機能はないので、Write-Hostで色をつける - $tableLayout = "{0,-75} {1,-15} {2,-15} {3,-15} {4,-15} {5,-10}" + $tableLayout = "{0,-75} {1,-15} {2,-15} {3,-15} {4,-15} {5,-10} {5,-10} {5,-10}" Write-Host ($tableLayout -f ` "Log File", ` "Current Size", ` @@ -1495,7 +1495,10 @@ function AuditFileSize { "--------", ` "------", ` "-----------", ` - "--------------") + "--------------", ` + "--------------", ` + "--------" ` + ) foreach ($result in $results) { $color = if ($result.CorrectSetting -eq "Y") { "Green" } else { "Red" } Write-Host ($tableLayout -f ` From 022ae40c1e1747ccfdce3cac57c5c7077be783c2 Mon Sep 17 00:00:00 2001 From: fukusuket <41001169+fukusuket@users.noreply.github.com> Date: Sun, 20 Apr 2025 16:21:05 +0900 Subject: [PATCH 03/14] feat: full/rotate check --- WELA.ps1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/WELA.ps1 b/WELA.ps1 index 0a65ef7a..d6c9b903 100644 --- a/WELA.ps1 +++ b/WELA.ps1 @@ -1478,7 +1478,7 @@ function AuditFileSize { } # Format-Tableには色つき出力の機能はないので、Write-Hostで色をつける - $tableLayout = "{0,-75} {1,-15} {2,-15} {3,-15} {4,-15} {5,-10} {5,-10} {5,-10}" + $tableLayout = "{0,-75} {1,-15} {2,-15} {3,-15} {4,-15} {5,-10} {6,-10} {7,-10}" Write-Host ($tableLayout -f ` "Log File", ` "Current Size", ` From 59619f09661dbb286169261b3f6e23790c42f5ea Mon Sep 17 00:00:00 2001 From: fukusuket <41001169+fukusuket@users.noreply.github.com> Date: Sun, 20 Apr 2025 16:22:17 +0900 Subject: [PATCH 04/14] feat: full/rotate check --- WELA.ps1 | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/WELA.ps1 b/WELA.ps1 index d6c9b903..dcc42f2f 100644 --- a/WELA.ps1 +++ b/WELA.ps1 @@ -1478,7 +1478,7 @@ function AuditFileSize { } # Format-Tableには色つき出力の機能はないので、Write-Hostで色をつける - $tableLayout = "{0,-75} {1,-15} {2,-15} {3,-15} {4,-15} {5,-10} {6,-10} {7,-10}" + $tableLayout = "{0,-75} {1,-15} {2,-10} {3,-10} {4,-10} {5,-10} {6,-10} {7,-10}" Write-Host ($tableLayout -f ` "Log File", ` "Current Size", ` @@ -1486,7 +1486,7 @@ function AuditFileSize { "Default", ` "Recommended", ` "Correct Setting", ` - "Is Log Full", ` + "Log Full", ` "Log Mode" ` ) Write-Host ($tableLayout -f ` @@ -1496,8 +1496,8 @@ function AuditFileSize { "------", ` "-----------", ` "--------------", ` - "--------------", ` - "--------" ` + "-------", ` + "-------" ` ) foreach ($result in $results) { $color = if ($result.CorrectSetting -eq "Y") { "Green" } else { "Red" } From 2e65e19769cd84858b9d6167b0951fa226b10740 Mon Sep 17 00:00:00 2001 From: fukusuket <41001169+fukusuket@users.noreply.github.com> Date: Sun, 20 Apr 2025 16:23:07 +0900 Subject: [PATCH 05/14] feat: full/rotate check --- WELA.ps1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/WELA.ps1 b/WELA.ps1 index dcc42f2f..1a6b1b24 100644 --- a/WELA.ps1 +++ b/WELA.ps1 @@ -1478,7 +1478,7 @@ function AuditFileSize { } # Format-Tableには色つき出力の機能はないので、Write-Hostで色をつける - $tableLayout = "{0,-75} {1,-15} {2,-10} {3,-10} {4,-10} {5,-10} {6,-10} {7,-10}" + $tableLayout = "{0,-75} {1,-15} {2,-12} {3,-12} {4,-12} {5,-12} {6,-12} {7,-12}" Write-Host ($tableLayout -f ` "Log File", ` "Current Size", ` From 039e184a7bed7b60a1b6de41e9e88e3451b16455 Mon Sep 17 00:00:00 2001 From: fukusuket <41001169+fukusuket@users.noreply.github.com> Date: Sun, 20 Apr 2025 16:24:58 +0900 Subject: [PATCH 06/14] feat: full/rotate check --- WELA.ps1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/WELA.ps1 b/WELA.ps1 index 1a6b1b24..d85d91d0 100644 --- a/WELA.ps1 +++ b/WELA.ps1 @@ -1478,7 +1478,7 @@ function AuditFileSize { } # Format-Tableには色つき出力の機能はないので、Write-Hostで色をつける - $tableLayout = "{0,-75} {1,-15} {2,-12} {3,-12} {4,-12} {5,-12} {6,-12} {7,-12}" + $tableLayout = "{0,-75} {1,-15} {2,-15} {3,-15} {4,-15} {5,-15} {6,-15} {7,-15}" Write-Host ($tableLayout -f ` "Log File", ` "Current Size", ` From e248ee61ea94235b28a708494e1c85054983e63e Mon Sep 17 00:00:00 2001 From: fukusuket <41001169+fukusuket@users.noreply.github.com> Date: Sun, 20 Apr 2025 16:26:37 +0900 Subject: [PATCH 07/14] feat: full/rotate check --- WELA.ps1 | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/WELA.ps1 b/WELA.ps1 index d85d91d0..f2a5da81 100644 --- a/WELA.ps1 +++ b/WELA.ps1 @@ -1471,23 +1471,23 @@ function AuditFileSize { MaxLogSize = "$maxLogSize MB" Default = $logNames[$logName][0] Recommended = $logNames[$logName][1] - CorrectSetting = $correctSetting IsLogFull = $logInfo.IsLogFull LogMode = $logInfo.LogMode + CorrectSetting = $correctSetting } } # Format-Tableには色つき出力の機能はないので、Write-Hostで色をつける - $tableLayout = "{0,-75} {1,-15} {2,-15} {3,-15} {4,-15} {5,-15} {6,-15} {7,-15}" + $tableLayout = "{0,-75} {1,-15} {2,-10} {3,-10} {4,-10} {5,-10} {6,-10} {7,-10}" Write-Host ($tableLayout -f ` "Log File", ` "Current Size", ` "Max Size", ` "Default", ` "Recommended", ` - "Correct Setting", ` "Log Full", ` - "Log Mode" ` + "Log Mode", ` + "Correct Setting" ` ) Write-Host ($tableLayout -f ` "--------", ` @@ -1495,9 +1495,9 @@ function AuditFileSize { "--------", ` "------", ` "-----------", ` - "--------------", ` "-------", ` - "-------" ` + "-------", ` + "--------------" ` ) foreach ($result in $results) { $color = if ($result.CorrectSetting -eq "Y") { "Green" } else { "Red" } @@ -1507,9 +1507,9 @@ function AuditFileSize { $result.MaxLogSize, ` $result.Default, ` $result.Recommended, ` - $result.CorrectSetting, ` $result.IsLogFull, ` - $result.LogMode ` + $result.LogMode, ` + $result.CorrectSetting ` ) -ForegroundColor $color } From 02e4567288703365fcfcbf872010dedd4f73b02b Mon Sep 17 00:00:00 2001 From: fukusuket <41001169+fukusuket@users.noreply.github.com> Date: Sun, 20 Apr 2025 16:27:13 +0900 Subject: [PATCH 08/14] feat: full/rotate check --- WELA.ps1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/WELA.ps1 b/WELA.ps1 index f2a5da81..9e9e0780 100644 --- a/WELA.ps1 +++ b/WELA.ps1 @@ -1478,7 +1478,7 @@ function AuditFileSize { } # Format-Tableには色つき出力の機能はないので、Write-Hostで色をつける - $tableLayout = "{0,-75} {1,-15} {2,-10} {3,-10} {4,-10} {5,-10} {6,-10} {7,-10}" + $tableLayout = "{0,-75} {1,-15} {2,-10} {3,-10} {4,-15} {5,-10} {6,-10} {7,-10}" Write-Host ($tableLayout -f ` "Log File", ` "Current Size", ` From 0aa44afdd3257ff3488bd2dec520ac8869775166 Mon Sep 17 00:00:00 2001 From: fukusuket <41001169+fukusuket@users.noreply.github.com> Date: Sun, 20 Apr 2025 16:27:35 +0900 Subject: [PATCH 09/14] feat: full/rotate check --- WELA.ps1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/WELA.ps1 b/WELA.ps1 index 9e9e0780..b612d8b8 100644 --- a/WELA.ps1 +++ b/WELA.ps1 @@ -1478,7 +1478,7 @@ function AuditFileSize { } # Format-Tableには色つき出力の機能はないので、Write-Hostで色をつける - $tableLayout = "{0,-75} {1,-15} {2,-10} {3,-10} {4,-15} {5,-10} {6,-10} {7,-10}" + $tableLayout = "{0,-75} {1,-15} {2,-10} {3,-10} {4,-15} {5,-10} {6,-15} {7,-10}" Write-Host ($tableLayout -f ` "Log File", ` "Current Size", ` From 477526171026019d7be4f134845a33bd2ea14972 Mon Sep 17 00:00:00 2001 From: fukusuket <41001169+fukusuket@users.noreply.github.com> Date: Sun, 20 Apr 2025 16:28:03 +0900 Subject: [PATCH 10/14] feat: full/rotate check --- WELA.ps1 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/WELA.ps1 b/WELA.ps1 index b612d8b8..8d7c1966 100644 --- a/WELA.ps1 +++ b/WELA.ps1 @@ -1495,8 +1495,8 @@ function AuditFileSize { "--------", ` "------", ` "-----------", ` - "-------", ` - "-------", ` + "--------", ` + "--------", ` "--------------" ` ) foreach ($result in $results) { From fe53a9fb5843fda094ec839e5931fd445236198e Mon Sep 17 00:00:00 2001 From: fukusuket <41001169+fukusuket@users.noreply.github.com> Date: Sun, 20 Apr 2025 16:37:15 +0900 Subject: [PATCH 11/14] feat: full/rotate check --- WELA.ps1 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/WELA.ps1 b/WELA.ps1 index 8d7c1966..ebd3c6f5 100644 --- a/WELA.ps1 +++ b/WELA.ps1 @@ -1464,6 +1464,7 @@ function AuditFileSize { $maxLogSize = [math]::Floor($logInfo.MaximumSizeInBytes / 1MB) $recommendedSize = [int]($logNames[$logName][1] -replace " MB\+?", "") $correctSetting = if ($maxLogSize -ge $recommendedSize) { "Y" } else { "N" } + $logIsFull = $logInfo.FileSize -gt $logInfo.MaximumSizeInBytes $results += [PSCustomObject]@{ LogFile = Split-Path $logInfo.LogFilePath -Leaf @@ -1471,7 +1472,7 @@ function AuditFileSize { MaxLogSize = "$maxLogSize MB" Default = $logNames[$logName][0] Recommended = $logNames[$logName][1] - IsLogFull = $logInfo.IsLogFull + IsLogFull = $logIsFull LogMode = $logInfo.LogMode CorrectSetting = $correctSetting } From ccfbbccb80d44d94b437fc4935a73f7c11721a16 Mon Sep 17 00:00:00 2001 From: fukusuket <41001169+fukusuket@users.noreply.github.com> Date: Sun, 20 Apr 2025 16:53:58 +0900 Subject: [PATCH 12/14] feat: full/rotate check --- WELA.ps1 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/WELA.ps1 b/WELA.ps1 index ebd3c6f5..b8bde615 100644 --- a/WELA.ps1 +++ b/WELA.ps1 @@ -1486,7 +1486,7 @@ function AuditFileSize { "Max Size", ` "Default", ` "Recommended", ` - "Log Full", ` + "Is Log Full", ` "Log Mode", ` "Correct Setting" ` ) @@ -1496,7 +1496,7 @@ function AuditFileSize { "--------", ` "------", ` "-----------", ` - "--------", ` + "-----------", ` "--------", ` "--------------" ` ) From 254731289831c5e36a49895e86a276b59bfe7196 Mon Sep 17 00:00:00 2001 From: fukusuket <41001169+fukusuket@users.noreply.github.com> Date: Sun, 20 Apr 2025 16:54:29 +0900 Subject: [PATCH 13/14] feat: full/rotate check --- WELA.ps1 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/WELA.ps1 b/WELA.ps1 index b8bde615..bdc5ef1d 100644 --- a/WELA.ps1 +++ b/WELA.ps1 @@ -1486,7 +1486,7 @@ function AuditFileSize { "Max Size", ` "Default", ` "Recommended", ` - "Is Log Full", ` + "Is Full", ` "Log Mode", ` "Correct Setting" ` ) @@ -1496,7 +1496,7 @@ function AuditFileSize { "--------", ` "------", ` "-----------", ` - "-----------", ` + "-------", ` "--------", ` "--------------" ` ) From 4ac03858429c35830df53fedb6ada26ebe7903cc Mon Sep 17 00:00:00 2001 From: fukusuket <41001169+fukusuket@users.noreply.github.com> Date: Mon, 21 Apr 2025 07:19:36 +0900 Subject: [PATCH 14/14] chg: retain -> nooverwrite --- WELA.ps1 | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/WELA.ps1 b/WELA.ps1 index bdc5ef1d..fbecaf6c 100644 --- a/WELA.ps1 +++ b/WELA.ps1 @@ -1463,8 +1463,9 @@ function AuditFileSize { $logInfo = Get-WinEvent -ListLog $logName -ErrorAction Stop $maxLogSize = [math]::Floor($logInfo.MaximumSizeInBytes / 1MB) $recommendedSize = [int]($logNames[$logName][1] -replace " MB\+?", "") - $correctSetting = if ($maxLogSize -ge $recommendedSize) { "Y" } else { "N" } $logIsFull = $logInfo.FileSize -gt $logInfo.MaximumSizeInBytes + $logMode = if ($logInfo.LogMode -eq "Retain") { "NoOverwrite" } else { $logInfo.LogMode } + $correctSetting = if ($maxLogSize -ge $recommendedSize -and $logMode -ne "NoOverwrite") { "Y" } else { "N" } $results += [PSCustomObject]@{ LogFile = Split-Path $logInfo.LogFilePath -Leaf @@ -1473,7 +1474,7 @@ function AuditFileSize { Default = $logNames[$logName][0] Recommended = $logNames[$logName][1] IsLogFull = $logIsFull - LogMode = $logInfo.LogMode + LogMode = $logMode CorrectSetting = $correctSetting } }